Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-1260 add Outcome Date filter #794

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

Scarlett-Truong
Copy link
Collaborator

@Scarlett-Truong Scarlett-Truong commented Dec 4, 2024

Description

Add Outcome Date filter
Fix css bug of Outcome Animal filter "Dead on arrival" was cropped out

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test if Outcome Date filter by itself works as expected for either complaints with one outcome or complaints with multiple outcome animal.
  • Test if combination of Outcome Date filters with other filters (Zone, Outcome by Animal, etc..) works as expected
  • Do the same of the above with map view
  • Test if "Date logged" filter works as expected as code is refactored
  • Check if first option (Dead on arrival) of Outcome Animal filter is visible (not cropped out)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@Scarlett-Truong Scarlett-Truong changed the base branch from main to release/0.6.9 December 4, 2024 23:17
@Scarlett-Truong Scarlett-Truong added the case_management_1 https://dc0a4a-compenf-dev-1-backend.apps.emerald.devops.gov.bc.ca/graphql label Dec 5, 2024
Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@afwilcox afwilcox merged commit 166e50f into release/0.6.9 Dec 9, 2024
16 checks passed
@afwilcox afwilcox deleted the feat/CE-1260 branch December 9, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
case_management_1 https://dc0a4a-compenf-dev-1-backend.apps.emerald.devops.gov.bc.ca/graphql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants