fix(1469): handle the situation when all roles failed to grant, no em…

…ail should send, refs: #1469
bcgov · Aug 14, 2024 · 172ae33 · 172ae33
1 parent bff7e41
commit 172ae33
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/server/admin_management/api/app/integration/gc_notify.py b/server/admin_management/api/app/integration/gc_notify.py
@@ -8,6 +8,7 @@
 
 GC_NOTIFY_EMAIL_BASE_URL = "https://api.notification.canada.ca"
 GC_NOTIFY_GRANT_DELEGATED_ADMIN_EMAIL_TEMPLATE_ID = "9abff613-e507-4562-aae0-008317dfe3b9"
+# Template id for granting application admin, we will use this later
 GC_NOTIFY_GRANT_APP_ADMIN_EMAIL_TEMPLATE_ID = "230bca59-4906-40b2-8f2b-2f6186a98663"
 
 

diff --git a/server/admin_management/api/app/services/access_control_privilege_service.py b/server/admin_management/api/app/services/access_control_privilege_service.py
@@ -230,6 +230,9 @@ def send_email_notification(
                 )
             )
 
+            if granted_roles == "":  # no role is granted
+                return
+
             gc_notify_email_service = GCNotifyEmailService()
             email_response = gc_notify_email_service.send_delegated_admin_granted_email(
                 schemas.GCNotifyGrantDelegatedAdminEmailParam(