Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update morecast link on landing page #4013

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Update morecast link on landing page #4013

merged 3 commits into from
Oct 17, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 16, 2024

  • Change link on landing page to /morecast
  • Update config map with new Miro board URL

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (6b15aa7) to head (7822264).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
web/src/features/landingPage/toolInfo.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4013   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files         302      302           
  Lines       11456    11456           
  Branches      549      549           
=======================================
  Hits         9171     9171           
  Misses       2100     2100           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested review from conbrad and brettedw October 16, 2024 22:19
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also change/remove the variables that include 2? e.g. MORE_CAST_2_NAME, moreCast2Info, etc

Copy link

@dgboss
Copy link
Collaborator Author

dgboss commented Oct 17, 2024

Can we also change/remove the variables that include 2? e.g. MORE_CAST_2_NAME, moreCast2Info, etc

Done in 7822264

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for cleaning that up!

@dgboss dgboss temporarily deployed to production October 17, 2024 21:46 Inactive
@dgboss dgboss merged commit 8612af3 into main Oct 17, 2024
25 checks passed
@dgboss dgboss deleted the task/landing-page-updates branch October 17, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants