-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/KBDEV-1194 get updated studies for last two weeks in clinicaltrials #143
task/KBDEV-1194 get updated studies for last two weeks in clinicaltrials #143
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@sshugsc, to be safe, testing with some other loaders via the CLI would be a must before merging. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
@sshu, can you post here which loaders you tested (the command you used) so we may want to use the same ones for testing the CLI from now on? I'm curious; have you choose one file loader, one api, cosmic and civic, in conjunction with the maxRecords flag? |
I tested file loaders(ncit, refseq), api loaders(oncotree, docm), cosmic (resistance) and civic. They all work fine. |
oh, that's a lot! Not the whole datasets I suppose; have you used the maxRecords flag? |
yeah, tried maxRecords flag for them. Work good on most of them, but oncotree didn't support it. |
KBDEV-1194