Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PackageLicenseExpression, remove deprecated PackageLicenseUrl. #583

Closed
wants to merge 2 commits into from

Conversation

bchavez
Copy link
Owner

@bchavez bchavez commented Feb 20, 2025

Remove deprecated PackageLicenseUrl and use PackageLicenseExpression for main Bogus package. Fixes #499.

@bchavez bchavez changed the title Use PackageLicenseExpression, remove deprecated PackageLicenseUrl. Fixes #499. Use PackageLicenseExpression, remove deprecated PackageLicenseUrl. Feb 20, 2025
@bchavez
Copy link
Owner Author

bchavez commented Feb 20, 2025

There does not seem to be a way to maintain copyright holder names with PackageLicenseExpression only changes:

The <licenseUrl> points to license templates on NuGet.
image

image

I don't think it will be possible to omit the license URL if we want to maintain the copyright holder names.

@bchavez
Copy link
Owner Author

bchavez commented Feb 20, 2025

Build failure when trying to use both:

image

image

@bchavez
Copy link
Owner Author

bchavez commented Feb 20, 2025

Can't use PackageLicenseExpression and PackageLicenseFIle either:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Direct License Information In Nuget metadata
1 participant