This repository has been archived by the owner on Feb 21, 2020. It is now read-only.
Development #47
Open
Development #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge for release 1.0.0
Release 1.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, there is a potential bug when a character equal to -1 is sent by serial port; in this case according the current implementation the following character in queue is not transmitted. For this reason I propose to simplify _tx_complete_irq implementation just returning 0 if we still have characters to be transmitted, -1 otherwise.
I also added a flow control in USB serial in order to improve the performances when USB serial is combined with real serial ports