Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: composability #29

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

feat: composability #29

wants to merge 2 commits into from

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Mar 6, 2025

PR-Codex overview

This PR focuses on updates to the SDK, including version bumping, refactoring of network handling, and the introduction of new module functionalities. It enhances the account creation process and improves factory data handling.

Detailed summary

  • Deleted src/sdk/account/decorators/getNexusAddress.test.ts
  • Updated package.json version from 0.2.1 to 0.2.2
  • Refactored toNetwork function to remove the hardcoded network string
  • Introduced toEmptyHook and toComposableExecutor with respective configurations
  • Updated getNexusAddress to use new universal address logic
  • Removed unnecessary validatorAddress and factoryAddress from multiple client creations
  • Added new constants for MEE_VALIDATOR_ADDRESS and COMPOSABLE_EXECUTOR_ADDRESS
  • Improved module formatting in toNexusAccount
  • Enhanced error handling for network operations
  • Updated tests to reflect the new structure and functionalities

The following files were skipped due to too many changes: src/sdk/account/toNexusAccount.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Mar 6, 2025

size-limit report 📦

Path Size
core (esm) 43.96 KB (+0.53% 🔺)
core (cjs) 56.18 KB (+0.42% 🔺)
bundler (tree-shaking) 6.05 KB (0%)
paymaster (tree-shaking) 543 B (0%)

@joepegler joepegler force-pushed the feat/composability branch 8 times, most recently from 164a547 to ca83b20 Compare March 11, 2025 18:12
@joepegler joepegler force-pushed the feat/composability branch from ca83b20 to 30acef1 Compare March 11, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant