Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add target and payment chains #6

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Jan 21, 2025

PR-Codex overview

This PR primarily focuses on refactoring the handling of chain parameters in the codebase, replacing instances of chain with toChain for clarity and consistency. It also enhances the management of fee tokens and updates various test cases accordingly.

Detailed summary

  • Changed chain to toChain in build.ts, buildIntent.ts, and other related files.
  • Updated fee token handling in getQuote, signQuote, and executeQuote.
  • Adjusted test cases to reflect changes in chain parameters.
  • Improved type safety for deployments in toMultiChainNexusAccount.
  • Ensured consistent use of targetChain across multiple files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joepegler joepegler force-pushed the chore/target_and_payment_chains branch from 7ff581a to 2a5ff8f Compare January 21, 2025 12:38
@joepegler joepegler force-pushed the chore/target_and_payment_chains branch from 2a5ff8f to d00c0f9 Compare January 21, 2025 12:44
Copy link

github-actions bot commented Jan 21, 2025

size-limit report 📦

Path Size
core (esm) 36.64 KB (+0.27% 🔺)
core (cjs) 45.98 KB (+0.24% 🔺)
bundler (tree-shaking) 523 B (0%)
paymaster (tree-shaking) 543 B (0%)

@joepegler joepegler force-pushed the chore/target_and_payment_chains branch from f1a3bf4 to add19ed Compare January 21, 2025 16:40
chore: tidy strictMode
@joepegler joepegler force-pushed the chore/target_and_payment_chains branch from add19ed to db966c3 Compare January 21, 2025 16:40
@joepegler joepegler merged commit 510414a into develop Jan 22, 2025
5 checks passed
@joepegler joepegler deleted the chore/target_and_payment_chains branch January 22, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant