SMA-355 [WIP] Gas Optimisations #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMA-355 Gas Optimization SCW-Contract ⛽️
Implement gas optimizations on the current stable version of the SCW contract. This phase prioritizes the enhancement of existing implementations, focusing on core implementation and widely used modules. Completing this milestone may require coordinating with auditors if significant changes are made. |
filmakarov
reviewed
Nov 30, 2023
Aboudjem
approved these changes
Dec 22, 2023
| @@ -28,6 +28,6 @@ interface ISignatureValidator { | |||
| */ | |||
| function isValidSignatureUnsafe( | |||
| bytes32 dataHash, | |||
| bytes memory moduleSignature | |||
| bytes calldata moduleSignature | |||
There was a problem hiding this comment.
any specific rationale for this?
There was a problem hiding this comment.
calldata can be sliced => cheaper
contracts/smart-account/modules/EcdsaOwnershipRegistryModule.sol
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gas Optimisations
Related Issue: #SMA-355
Change Type
Checklist