Aggregated Audit Remediations #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingrockrises
approved these changes
Feb 16, 2024
| import {Executor, Enum} from "./Executor.sol"; | ||
| import {IModuleManager} from "../interfaces/base/IModuleManager.sol"; | ||
|
|
||
| /** | ||
| * @title Module Manager - A contract that manages modules that can execute transactions | ||
| * on behalf of the Smart Account via this contract. | ||
| */ | ||
| abstract contract ModuleManager is SelfAuthorized, Executor, IModuleManager { | ||
| abstract contract ModuleManager is Executor, IModuleManager { |
There was a problem hiding this comment.
this change is under which category?
There was a problem hiding this comment.
under remove unused code
Aboudjem
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Report 1. Link
Issues 1, 2, 6, 7, 11 Fixed.
The rest do not need fix as of now or will be removed from the report as per meeting from 07 Feb
Related Issue: SMA-234
Change Type
Checklist