wallet-http: create account: remove unused 'watch-only'

[pinheadmz]

When a new account is created, it inherits its watch-only property from the wallet that contains it. By removing this check, user will get "unrecognized option" error if they try to create an account with watch-only. Currently the parameter is just ignored and could cause user confusion.

[tuxcanfly]

OK.

[braydonf]

So in testing, I didn't find a difference in behavior.

Using the example at #688 with the addition of:

const res = await client.request('PUT', '/wallet/:id/account/:account', {
  accountKey: xpub,
  watchOnly: false,
  type: 'pubkeyhash'
});

The response gave watchOnly: true for the account in that case.

[pinheadmz]

I think this makes more sense in the context of this bclient PR: bcoin-org/bclient#15 and #639

Those PRs actually throw errors, this one just cleans up an unused line of code (exactly how you described -- the example creates a watchonly wallet, so all its accounts will be watchonly, regardless of the option you pass)

not sure what I meant in comment 1 about feedback to the user -crossing out!

[braydonf]

The commit message still has the now crossed out line, fyi.

[nodech]

Looks good.

[codecov-io]

Codecov Report

Merging #637 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   53.17%   53.33%   +0.15%     
==========================================
  Files         104      104              
  Lines       27719    27676      -43     
  Branches     4749     4738      -11     
==========================================
+ Hits        14740    14760      +20     
+ Misses      12979    12916      -63

Impacted Files	Coverage Δ
lib/wallet/http.js	44.4% <ø> (ø)	⬆️
lib/workers/child.js	66.66% <0%> (-1.24%)	⬇️
lib/mempool/mempool.js	43.42% <0%> (-1.11%)	⬇️
lib/primitives/keyring.js	69.97% <0%> (-1%)	⬇️
lib/node/rpc.js	23.38% <0%> (-0.25%)	⬇️
lib/blockchain/chaindb.js	56.78% <0%> (-0.1%)	⬇️
lib/blockchain/chain.js	60.55% <0%> (-0.08%)	⬇️
lib/net/pool.js	15.87% <0%> (-0.05%)	⬇️
lib/wallet/walletdb.js	75.47% <0%> (-0.03%)	⬇️
lib/wallet/txdb.js	79.88% <0%> (-0.02%)	⬇️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a25e0...9ecb19f. Read the comment docs.

[pinheadmz]

@braydonf removed the comment from the commit message, guess thats from github web interface

[braydonf]

Merged at bb1ce25