Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MultisigWallet more compatible to WalletClient #7

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Make MultisigWallet more compatible to WalletClient #7

merged 3 commits into from
Feb 7, 2019

Conversation

nodech
Copy link
Member

@nodech nodech commented Feb 6, 2019 •
edited
Loading

  • Add all non supported methods and throw error.
  • Add account parameter back to methods but assert its default
  • Make account param "default" by default.

This PR includes both of these:
#1 and #3

@nodech nodech requested review from BluSyn and tynes February 6, 2019 16:01
@BluSyn
Copy link

BluSyn commented Feb 6, 2019

👍
I have closed my PR, since this is actually more what I was intending.

My only concern is lots of duplicate code from bclient in the MultisigWallet class. It would help to be able to just extend Wallet.

This can be done if this is merged in:
bcoin-org/bclient#18

@nodech
Copy link
Member Author

nodech commented Feb 7, 2019

Merging this branch, we can have another clean up PR after bclient PR is merged.

@nodech nodech merged commit 122632e into bcoin-org:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BluSyn BluSyn Awaiting requested review from BluSyn

@tynes tynes Awaiting requested review from tynes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nodech @BluSyn