Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Generator class instead of dump method for config generation #143

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

ton31337
Copy link
Contributor

Use Generator class instead of dump method for config generation.

[2017-04-11T05:52:05+00:00] ERROR: influxdb_config[/etc/influxdb/influxdb.conf] (influxdb::default line 20) had an error: NoMethodError: undefined method `dump' for TOML:Module

@bdangit
Copy link
Owner

bdangit commented Apr 12, 2017

Hi @ton31337,

We are actually using toml-rb instead of toml ruby gem. We made this change in #98. Looking at both projects, toml-rb appears to be more active compared to toml. Other than that, I can't say I understand why we moved to toml-rb though. @alvaromorales maybe able to speak to that.

Is there another chef cookbook that has a toml depdendency?

@alaa
Copy link

alaa commented Apr 13, 2017

This helped until we have different namespace chef_gem 'toml' { action :remove }

@bdangit
Copy link
Owner

bdangit commented Apr 13, 2017

@alaa, ah good workaround, but I would imagine its removing and installing toml gems over and over again during converges.

@bdangit
Copy link
Owner

bdangit commented Apr 26, 2017

alright as part of debugging #144, chef 13 now depends on inspec ref: https://github.com/chef/chef/blob/122f2804f573977f9d88d4987988cd68ba785bed/Gemfile#L24 And inspec depends on toml. While the maintainer of toml gem isn't so frequent, I'm going to based on that chef depends toml and that the chef community is far greater than the community of the toml.

WIth that i'm going to go ahead and approve this PR.

@bdangit bdangit merged commit 3492de7 into bdangit:master Apr 26, 2017
@ton31337 ton31337 deleted the Fix/TOML_dump_chef13 branch April 26, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants