Error-handling cleanup, etc. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce D'Arcus <[email protected]>
Still work to do, but incrementally improve error-handling to reduce usage of unwrap and expect. Also, consolidate file parsing around a Parsable trait. Signed-off-by: Bruce D'Arcus <[email protected]>
Signed-off-by: Bruce D'Arcus <[email protected]>
|
Am just merging this, though it's not really finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not sure I want to merge all this, but am trying to better handle errors, and remove usage of
unwrapandexpect.I'm particularly uncertain about the change from specific file parsing methods on the respective structs to a single one for all of them, with the new
Parsabletrait. I included this in the very large last commit. I may split off that change into a separate commit, so it's easy to revert later.Also need to clean up/expand documentation.