Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test issue #66

Draft
wants to merge 2 commits into
base: MOODLE_3X_STABLE
Choose a base branch
from

Conversation

Ampsicora
Copy link

@Ampsicora Ampsicora commented Feb 7, 2024

Error:
core_calendar\container_test::test_delete_module_delete_events Error: Class 'block_deft\janus_room' not found

This fix #67 adding a check for the class block_deft\janus_room to exists in order to prevent a failing test

@golenkovm
Copy link

Thanks for raising this @Ampsicora

I's suggest to link this PR to the issue (if it doesn't exist feel free to create it). Also could you please provide the environment details this error is happening in? You can simply copy the header from your phpunit output (there are a few lines with Moodle, db, php, phpunit versions).

I wonder what is block_deft\janus_room. Is it a method that belonds to another 3rd party plugin block_deft?

I checked https://github.com/bdecentgmbh/moodle-mod_videotime/blob/master/version.php and there are no dependencies mentioned. Are there any more references to block_deft's methods in the plugin code?

@Ampsicora
Copy link
Author

These are the environment details:

Moodle 4.1.8+ (Build: 20240125)
Php: 7.4.33, mariadb: 10.5.23, OS: Linux 6.2.0-1017-aws x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

block_deft seems to be a relevant class since in the code various of its methods are used and has been extended by other classes

@golenkovm
Copy link

golenkovm commented Feb 7, 2024

This actually sounds like a dependency issue. If there are many references to block_deft plugin then it should be set as dependant in version.php and installed along with mod_videotime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants