fix crash calling nonexistent delegate (also memory leak) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coeur
reviewed
Nov 25, 2023
VDKQueue.m
Outdated
| _keepWatcherThreadRunning = NO; | ||
|
|
||
| // Do this to close all the open file descriptors for files we're watching | ||
| [_pathMap removeAllObjects]; |
There was a problem hiding this comment.
Maybe you were on a fork, because I don't think that pathMap exists.
There was a problem hiding this comment.
oops, yes, just disregard that line!
|
As present bdkjones repo is not maintained anymore, and as I am a maintainer for a fork of VDKQueue, I thank you for the suggested fix. I decided to implement it differently, without needing any new method: |
gobbledegook
force-pushed
the
delegatecrash
branch
from
4611071
to
3f1014f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch that fixes issue #19