Cycle 0 and Macro Fixes

- Homing cycle 0 was incorrectly running like -1 when run with $H<axis> - Eliminated a needless macro error when the macro was empty.
bdring · Nov 4, 2023 · 3a18102 · 3a18102
1 parent fc3a378
commit 3a18102
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/FluidNC/src/Machine/Axis.cpp b/FluidNC/src/Machine/Axis.cpp
@@ -45,7 +45,7 @@ namespace Machine {
                 m->init();
             }
         }
-        if (_homing->_cycle) {
+        if (_homing && _homing->_cycle != Machine::Homing::set_mpos_only) {
             _homing->init();
             set_bitnum(Axes::homingMask, _axis);
         }

diff --git a/FluidNC/src/Machine/Macros.cpp b/FluidNC/src/Machine/Macros.cpp
@@ -50,15 +50,15 @@ Cmd findOverride(std::string name) {
     return it == overrideCodes.end() ? Cmd::None : it->second;
 }
 
-bool Macro::run() {
-    if (sys.state != State::Idle) {
-        log_error("Macro can only be used in idle state");
+bool Macro::run() {  // return true if the macro was run
+    const std::string& s = _gcode;
+    if (_gcode == "") {
         return false;
     }
 
-    const std::string& s = _gcode;
-    if (_gcode == "") {
-        return true;
+    if (sys.state != State::Idle) {
+        log_error("Macro can only be used in idle state");
+        return false;
     }
 
     log_info("Running macro " << _name << ": " << _gcode);