Added all_messages config item to suppress chitchat on a channel

bdring · Dec 11, 2023 · 6db0190 · 6db0190
1 parent 3e94650
commit 6db0190
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/FluidNC/src/Channel.h b/FluidNC/src/Channel.h
@@ -50,6 +50,11 @@ class Channel : public Stream {
     bool       _reportWco = true;
     CoordIndex _reportNgc = CoordIndex::End;
 
+    // Set this to false to suppress messages sent to AllChannels
+    // It is useful for IO Expanders that do not want to be spammed
+    // with chitchat
+    bool _all_messages = true;
+
 public:
     Channel(const char* name, bool addCR = false) : _name(name), _linelen(0), _addCR(addCR) {}
     virtual ~Channel() = default;
@@ -104,6 +109,8 @@ class Channel : public Stream {
     int read() override { return -1; }
     int available() override { return _queue.size(); }
 
+    bool all_messages() { return _all_messages; }
+
     uint32_t     setReportInterval(uint32_t ms);
     uint32_t     getReportInterval() { return _reportInterval; }
     virtual void autoReport();

diff --git a/FluidNC/src/Serial.cpp b/FluidNC/src/Serial.cpp
@@ -233,7 +233,9 @@ void AllChannels::flushRx() {
 size_t AllChannels::write(uint8_t data) {
     _mutex_general.lock();
     for (auto channel : _channelq) {
-        channel->write(data);
+        if (channel->all_messages()) {
+            channel->write(data);
+        }
     }
     _mutex_general.unlock();
     return 1;
@@ -264,7 +266,9 @@ void AllChannels::stopJob() {
 size_t AllChannels::write(const uint8_t* buffer, size_t length) {
     _mutex_general.lock();
     for (auto channel : _channelq) {
-        channel->write(buffer, length);
+        if (channel->all_messages()) {
+            channel->write(buffer, length);
+        }
     }
     _mutex_general.unlock();
     return length;

diff --git a/FluidNC/src/UartChannel.h b/FluidNC/src/UartChannel.h
@@ -43,6 +43,7 @@ class UartChannel : public Channel, public Configuration::Configurable {
     void group(Configuration::HandlerBase& handler) override {
         handler.item("uart_num", _uart_num);
         handler.item("report_interval_ms", _report_interval_ms, 0, 5000);
+        handler.item("all_messages", _all_messages);
     }
 };