Change hidden password string to abide by minimum length #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I am not mistaken, this is the other half of the changes needed to allow for Esp3dUI V3 with #1044. If that gets working, it might help lighten the Dev load of FluidNC? Seems to be getting more and more widely adopted and I am seeing it getting used a lot more. |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For editing the WebUI, we currently send a string to hide passwords of length 6, "******".
WebUI 2 doesn't warn about min length constraints, but WebUI3 does.
This PR adds two asterisks to abide by the hardcoded length of 8, but in reality the better fix is to use the _minLength field and make sure the fake string meets the constraints.
I tried to do this with std::string(_minLength, '*') but I couldn't get it to end up correct on the web side, so I reverted back to hard-coded. It could just be my lack of C/C++ experience, so maybe someone can change it to something more robust using _minLength.