Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFD rework #1324

Merged
merged 7 commits into from
Oct 27, 2024
Merged

VFD rework #1324

merged 7 commits into from
Oct 27, 2024

Conversation

atlaste
Copy link
Collaborator

@atlaste atlaste commented Sep 19, 2024

Per request of @MitchBradley I did some rework on the VFD code. Basically I moved all the VFD specific code that can reside in a task to said task, removing the requirement for IRAM there. That should free up some RAM... This implementation should be backward compatible.

Needs more people testing this! I'm happy to test it out on my H2A VFD of course.

@bdring
Copy link
Owner

bdring commented Sep 19, 2024

It works on my Huanyang.

@bdring
Copy link
Owner

bdring commented Sep 25, 2024

@atlaste Did you test on the H2A VFD yet?

@atlaste
Copy link
Collaborator Author

atlaste commented Sep 27, 2024

@atlaste Did you test on the H2A VFD yet?

Not yet; I wanted to do some proper unit testing and crash testing first, so I ended up spending a few evenings writing test code for that. That test succeeded, which means that I'm fairly sure that the RS485 RX/TX traffic of the code is the same for the spindles that I've tested.
The other test that I wanted to do is force a crash on the system, so we don't get into the IRAM mess again. I know how Mitch did that, so I'm going to hack something together in the code to mimick that behavior as well. I just haven't had time for that yet.

-- update.

The crash test fails. I'm not sure why, and it probably has nothing to do with the VFD changes. BUT: it's still important to figure this out. For reference: https://github.com/atlaste/FluidNC/blob/VFD_CrashTest/FluidNC/src/CrashTest.h with a little change in main.cpp to initialize it. Any move in RMT crashes the system.

@atlaste
Copy link
Collaborator Author

atlaste commented Oct 5, 2024

The H2A also works. Just need the crash test after the IRAM changes land, and then I'm confident it's fine to pull.

@atlaste
Copy link
Collaborator Author

atlaste commented Oct 5, 2024

Now that I know why my crash test crashed the CPU, I just moved the LD scripts back to DRAM to do the crash test. The VFD code itself wasn't the cause.

I haven't been able to crash the code ever since. I'm confident enough this works. Feel free to pull.

@MitchBradley MitchBradley changed the base branch from main to SteppingNoVTabs October 27, 2024 16:39
@MitchBradley MitchBradley merged commit 8e36c50 into bdring:SteppingNoVTabs Oct 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants