Raising priority of i2s task prevents main task time-slicing in #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe too "inconsequential" but through instrumentation I determined that the main task can interrupt the i2sout task while it is running. This happens about once per minute while motion is happening, or perhaps more.
I think this interruption is extremely unlikely to produce an observable effect, but in the worst case if the main task doesn't yield or block for a while, the i2sout task could stall by up to the timeslice interval, which I think is 1 ms.
I did an experiment where I raised the priority by one, and the interruptions never happened after that, and I saw no other effects.