Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Try enabling gradle enterprise (line#4923)
Motivation: Note that github secrets are not available for actions triggered by forked pull requests: [ref](https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks) We have two choices 1. Using `pull_request` events: - For push (merge) events, secrets are applied and the build cache is updated - For pull requests from forked repositories, the build cache isn't updated. This means we can't take advantage of the build cache when checking out and reviewing pull requests locally. - We can expect fewer cache uploaded, but higher hit rate 2. Using `pull_request_target` events: - For all opened pull requests, secrets are applied and the build cache is updated - For this type of event, the `.github` workflow files from the base commit is used. This means updating the `.github` workflow file can be tedious. (e.g. we need to merge changes we want to test to our forked repo, and then open a PR to verify changes) I think it's fine to go with option 1 for now. Perhaps we can pivot to option 2 later depending on how much pressure our gradle enterprise instance is experiencing. Unfortunately, the only way to test if this PR "works" is to push this commit to the `main` branch. Test result from my forked repo: - PR: jrhee17#10 - Build scan: https://ge.armeria.dev/s/hcdbl7vdcqbhc - CI: https://github.com/jrhee17/armeria/actions/runs/5201312954/jobs/9381342458#step:5:1601 The options provided in `settings.gradle` are straightforward from Step 1 in the provided manual. Modifications: - Add a environment variable for gradle enterprise access key - Add gradle enterprise configurations in `settings.gradle` Result: - Gradle enterprise integration
- Loading branch information