This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
feat(network-communication)!: More secure internal communication #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JumpLink
changed the title
wpf500
suggested changes
Jan 24, 2024
JumpLink
changed the title
|
I will merge the PR into #341, which will make it easier to implement the review changes. As long as the other services ignore the token, they should continue to work despite this change |
JumpLink
changed the title
JumpLink
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement JWT for internal communication to make it more secure.
This is currently untested because we need to implement the verification for the other services first and then we need to test this on Portainer.
Breaking Changes
BEABEE_SERVICE_SECRETis required