Feat: beam shell #817
Feat: beam shell #817
Conversation
luke-lombardi
force-pushed
the
ll/shell
branch
2 times, most recently
from
ea51e20 to
e39639c
Compare
| // Don't allow negative and 0-valued compute requests | ||
| if stubConfig.Runtime.Cpu <= 0 { | ||
| stubConfig.Runtime.Cpu = defaultContainerCpu | ||
| } | ||
|
|
||
| if stubConfig.Runtime.Memory <= 0 { | ||
| stubConfig.Runtime.Memory = defaultContainerMemory | ||
| } |
There was a problem hiding this comment.
Maybe make a validateContainerRequestParams for these checks and some of the others below? It would keep this section leaner.
There was a problem hiding this comment.
that makes sense. I copied this from one of the other places we spawn containers
There was a problem hiding this comment.
I think a step up from this is to also have a function to configure mounts, secrets, cpu, memory, and gpu stuff
There was a problem hiding this comment.
I agree, I just think it should be a separate PR
| echo "if [ -f /root/.bashrc ]; then . /root/.bashrc; fi" >> "/root/.profile"; | ||
| echo "cd /mnt/code" >> "/root/.profile"; | ||
| echo "export TERM=xterm-256color" >> "/root/.bashrc"; | ||
| echo "alias ls='ls --color=auto'" >> "/root/.bashrc"; | ||
| echo "alias ll='ls -lart --color=auto'" >> "/root/.bashrc"; | ||
| sed -i 's/^#PasswordAuthentication.*/PasswordAuthentication yes/' /etc/ssh/sshd_config; | ||
| sed -i 's/^#PermitRootLogin.*/PermitRootLogin yes/' /etc/ssh/sshd_config; | ||
| sed -i 's/^#PubkeyAuthentication.*/PubkeyAuthentication no/' /etc/ssh/sshd_config; | ||
| echo "AllowUsers $USERNAME" >> /etc/ssh/sshd_config; | ||
| echo "PermitUserEnvironment yes" >> /etc/ssh/sshd_config; |
There was a problem hiding this comment.
What if we read-only mounted the sshd_config and .bashrc and then just copy the contents over in this command. My thinking is that it would clean this up a bit and also let us change bashrc without releasing.
Adds a shell command to let users connect to containers with their stub config. It can be used with any decorator that inherits from the `DeployableMixin`. <img width="609" alt="Screenshot 2025-01-01 at 6 52 13 PM" src="https://github.com/user-attachments/assets/0d8232fc-6215-40d7-bfdd-1f717e550aef" />
Adds a shell command to let users connect to containers with their stub config. It can be used with any decorator that inherits from the
DeployableMixin.