refactoring process_result function

beamkenya · Jun 20, 2020 · 5727367 · 5727367
1 parent 8ffecef
commit 5727367
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/lib/at_ex/gateway/Sms/bulk.ex b/lib/at_ex/gateway/Sms/bulk.ex
@@ -22,15 +22,9 @@ defmodule AtEx.Gateway.Sms.Bulk do
       attrs
       |> Map.put(:username, username)
 
-    with {:ok, %{status: 201} = res} <- post("/messaging", params) do
-      process_result(res.body)
-    else
-      {:ok, val} ->
-        {:error, %{status: val.status, message: val.body}}
-
-      {:error, message} ->
-        {:error, message}
-    end
+    "/messaging"
+    |> post(params)
+    |> process_result()
   end
 
   @doc """

diff --git a/lib/at_ex/gateway/base_http.ex b/lib/at_ex/gateway/base_http.ex
@@ -49,9 +49,13 @@ defmodule AtEx.Gateway.Base do
       Process results from calling the gateway
       """
       def process_result(result) do
-        with {:ok, res} <- Jason.decode(result) do
-          {:ok, res}
-        else
+        case result do
+          {:ok, %{status: 201} = res} ->
+            Jason.decode(res.body)
+
+          {:ok, val} ->
+            {:error, %{status: val.status, message: val.body}}
+
           {:error, val} ->
             {:error, val}
         end