Merge pull request #40 from beamkenya/refactor_sms

Refactor of SMS

lib/at_ex/gateway/Sms/bulk.ex

@@ -22,20 +22,14 @@ defmodule AtEx.Gateway.Sms.Bulk do
       attrs
       |> Map.put(:username, username)
 
-    with {:ok, %{status: 201} = res} <- post("/messaging", params) do
-      {:ok, Jason.decode!(res.body)}
-    else
-      {:ok, val} ->
-        {:error, %{status: val.status, message: val.body}}
-
-      {:error, message} ->
-        {:error, message}
-    end
+    "/messaging"
+    |> post(params)
+    |> process_result()
   end
 
   @doc """
   This function makes a get request to fetch an SMS via the Africa's talking SMS endpoint, this
-  function accepts an map of parameters that optionally accepts `lastReceivedId` of the message.
+  function accepts a map of parameters that optionally accepts `lastReceivedId` of the message.
   sent
 
   ## Parameters

lib/at_ex/gateway/base_http.ex

@@ -48,13 +48,21 @@ defmodule AtEx.Gateway.Base do
       @doc """
       Process results from calling the gateway
       """
-      def process_result(result) do
-        with {:ok, res} <- Jason.decode(result) do
-          {:ok, res}
-        else
-          {:error, val} ->
-            {:error, val}
-        end
+
+      def process_result({:ok, %{status: 200} = res}) do
+        Jason.decode(res.body)
+      end
+
+      def process_result({:ok, %{status: 201} = res}) do
+        Jason.decode(res.body)
+      end
+
+      def process_result({:ok, result}) do
+        {:error, %{status: result.status, message: result.body}}
+      end
+
+      def process_result({:error, result}) do
+        {:error, result}
       end
     end
   end