Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar and extra cell padding on first render of material table and when interacting with side navigation #245

Closed
sharon-ho opened this issue Jan 17, 2021 · 2 comments · Fixed by #435
Closed

Scrollbar and extra cell padding on first render of material table and when interacting with side navigation #245

sharon-ho opened this issue Jan 17, 2021 · 2 comments · Fixed by #435
Labels
bug Something isn't working frontend Issue related to developing the frontend (admin panel) non-critical Issues that we want to get done, but aren't critical to meet the sprint goals
Milestone
Sprint 9

Comments

@sharon-ho
Copy link
Member

Steps to reproduce:

  1. Run the app
  2. Go to the device list page
  3. Observe padding of row elements
  4. Switch between navigation menu items
  5. Double click on one navigation menu item

Expected result:
There should be no scrollbar and the padding shouldn't be as wide.

Actual result:
1610871900318
@sharon-ho sharon-ho added bug Something isn't working frontend Issue related to developing the frontend (admin panel) labels Jan 17, 2021
@sharon-ho sharon-ho changed the title Scrollbar and extra padding between cells on first render of material table and when interacting with side navigation Scrollbar and extra cell padding on first render of material table and when interacting with side navigation Jan 17, 2021
@sharon-ho
Copy link
Member Author

First mentioned in PR #202

@sharon-ho sharon-ho added this to the Sprint 6 milestone Jan 30, 2021
@felixlapierre felixlapierre removed this from the Sprint 6 milestone Mar 15, 2021
@sharon-ho sharon-ho added the non-critical Issues that we want to get done, but aren't critical to meet the sprint goals label Mar 28, 2021
@sharon-ho
Copy link
Member Author

Resolved in PR #435 by removing vertical tabs

@sharon-ho sharon-ho added this to the Sprint 9 milestone Apr 7, 2021
@sharon-ho sharon-ho linked a pull request Apr 7, 2021 that will close this issue
Refactor devicelist page #435
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Issue related to developing the frontend (admin panel) non-critical Issues that we want to get done, but aren't critical to meet the sprint goals
Projects
None yet
Milestone
Sprint 9
Development

Successfully merging a pull request may close this issue.

Refactor devicelist page bean-pod/switchboard
2 participants
@felixlapierre @sharon-ho