Refactor devicelist page #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJCipherButtles
temporarily deployed
to
bean-pod-pip-refactor-d-phgxk5
MrJCipherButtles
temporarily deployed
to
bean-pod-pip-refactor-d-phgxk5
MrJCipherButtles
temporarily deployed
to
bean-pod-pip-refactor-d-phgxk5
MrJCipherButtles
temporarily deployed
to
bean-pod-pip-refactor-d-phgxk5
MrJCipherButtles
temporarily deployed
to
bean-pod-pip-refactor-d-phgxk5
arejayelle
added
frontend
gdzooks
previously approved these changes
Apr 1, 2021
| @@ -149,6 +149,6 @@ export default function DevicesTable(props) { | |||
| } | |||
|
|
|||
| DevicesTable.propTypes = { | |||
| title: PropTypes.string.isRequired, | |||
| title: PropTypes.node.isRequired, | |||
There was a problem hiding this comment.
VERY SEXY that all you had to change in this file was this!!! \o/
|
Design feedback:
Overall tho i really love this change!! Great improvement!! |
felixlapierre
previously approved these changes
Apr 1, 2021
Comment on lines
+56
to
+65
| getTitle() { | ||
| const { selected } = this.state; | ||
| return ( | ||
| <DeviceTableTitle index={selected} handleChange={this.handleChange} /> | ||
| ); | ||
| } | ||
|
|
||
| render() { | ||
| return <DevicesTable devices={this.getDevices()} title={this.getTitle()} />; | ||
| } |
There was a problem hiding this comment.
Why did you choose to inject the entire title component into DevicesTable rather than just have it in DevicesTable?
There was a problem hiding this comment.
this makes it read cleaner and is easier to test
frontend/src/devicelist/__tests__/DeviceListPageContents.test.jsx
Outdated
Show resolved
Hide resolved
Peer programmed :) Co-authored-by: Felix Lapierre <[email protected]>
MrJCipherButtles
temporarily deployed
to
bean-pod-pip-refactor-d-phgxk5
MrJCipherButtles
temporarily deployed
to
bean-pod-pip-refactor-d-phgxk5
|
Kudos, SonarCloud Quality Gate passed! |
|
@felixlapierre issue #438 created to address interaction affordance |
felixlapierre
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General info
Issue number:
Task description:
Testing
Test coverage:
Additional notes
Note to reviewers:
To do before merging: