Functions context #196
Merged
Functions context #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
functions-context
branch
5 times, most recently
from
7b822fb
to
07cdc52
Compare
This argument is going away in a few commits, but rename it for now for clarity and to do not break everything during refactoring.
This allows functions implementations to access the evaluation context, especially other tables. The goal is to eliminate all BQL functions that take an implicit reference to the current evaluation row and are thus tied to queries on specific tables.
Make them take a reference to the evaluation context instead, and look up the required information from other tables. This allows to simplify the structure of the row returned by the postings table. meta(), entry_meta(), any_meta(), and has_account() cannot be updated to the new schema as they access the entry relative to the current posting. These functions will be deprecated and replaced by other constructs.
The function cannot be short-circuit when the third argument is NULL.
dnicolodi
force-pushed
the
functions-context
branch
from
09128f9
to
40e621e
Compare
The AST is rewritten to contain explicit references to the meta and entry.meta columns. This removes the need to pass the current row object (which is of the expected kind only when iterating the postings or entries tables) to the function evaluation.
dnicolodi
force-pushed
the
functions-context
branch
from
40e621e
to
73d9a43
Compare
dnicolodi
force-pushed
the
functions-context
branch
from
73d9a43
to
83493de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.