Skip to content

Commit

Permalink
a bug that should have been caught long time ago..
Browse files Browse the repository at this point in the history
  • Loading branch information
xji3 committed Apr 19, 2024
1 parent d82b6d2 commit cf3b8b6
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions src/dr/inference/operators/hmc/MassPreconditioner.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@
import dr.inference.model.*;
import dr.math.*;
import dr.math.distributions.MultivariateNormalDistribution;
import dr.math.matrixAlgebra.ReadableVector;
import dr.math.matrixAlgebra.RobustEigenDecomposition;
import dr.math.matrixAlgebra.WrappedMatrix;
import dr.math.matrixAlgebra.WrappedVector;
import dr.math.matrixAlgebra.*;
import dr.util.Transform;

import java.util.ArrayList;
Expand Down Expand Up @@ -720,10 +717,8 @@ protected void computeInverseMass() {

if (variance.getUpdateCount() > minimumUpdates) {
double[] newVariance = variance.getVariance();
// adaptiveDiagonal.update(new WrappedVector.Raw(newVariance));
// return normalizeVector(adaptiveDiagonal.getMean(), dim);
// setInverseMassFromArray(normalizeVector(new WrappedVector.Raw(newVariance), dim));
setInverseMassFromArray(DiagonalHessianPreconditioning.boundMassInverse(newVariance,
adaptiveDiagonal.update(new WrappedVector.Raw(newVariance));
setInverseMassFromArray(DiagonalHessianPreconditioning.boundMassInverse(((WrappedVector) adaptiveDiagonal.getMean()).getBuffer(),
options.preconditioningEigenLowerBound(), options.preconditioningEigenUpperBound(), dim,
DiagonalHessianPreconditioning.VarianceConverter.VARIANCE));
}
Expand Down

0 comments on commit cf3b8b6

Please sign in to comment.