Skip to content

Commit

Permalink
resolving AR conversations
Browse files Browse the repository at this point in the history
  • Loading branch information
jtmccr1 committed Nov 19, 2024
1 parent f9bb47c commit e6d89aa
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 21 deletions.
2 changes: 1 addition & 1 deletion src/dr/app/beast/development_parsers.properties
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#
# development_parsers.properties
#
# Copyright 2002-2024 the BEAST Development Team
# Copyright © 2002-2024 the BEAST Development Team
# http://beast.community/about
#
# This file is part of BEAST.
Expand Down
6 changes: 2 additions & 4 deletions src/dr/app/beauti/options/PartitionClockModel.java
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ public List<Operator> selectOperators(List<Operator> operators) {
List<Operator> ops = new ArrayList<Operator>();

if (options.hasData()) {
// if (getDataType().getType() != DataType.TREE) {
if (getDataType().getType() != DataType.TREE || getPartitionTreeModel().isUsingThorneyBEAST()) {
Operator rateOperator = getOperator("clock.rate");

switch (clockType) {
Expand Down Expand Up @@ -670,13 +670,11 @@ public List<Operator> selectOperators(List<Operator> operators) {

case AUTOCORRELATED:
throw new UnsupportedOperationException("Autocorrelated clock not implemented yet");
// break;

default:
throw new IllegalArgumentException("Unknown clock model");
}

// }
}
}

Parameter allMuNus = getParameter(options.useNuRelativeRates() ? "allNus" : "allMus");
Expand Down
4 changes: 0 additions & 4 deletions src/dr/app/beauti/options/PartitionTreeModel.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

package dr.app.beauti.options;

import dr.app.beauti.mcmcpanel.MCMCPanel;
import dr.app.beauti.types.*;
import dr.evolution.tree.Tree;

Expand Down Expand Up @@ -194,9 +193,6 @@ public List<Parameter> selectParameters(List<Parameter> parameters) {
// get parameter so their id prefix can be set.

getParameter("tree");
if(isUsingEmpiricalTrees()){
return parameters;
}
getParameter("treeModel.internalNodeHeights");
getParameter("treeModel.allInternalNodeHeights");

Expand Down
1 change: 0 additions & 1 deletion src/dr/app/beauti/sitemodelspanel/PartitionModelPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
import dr.app.beauti.types.FrequencyPolicyType;
import dr.app.beauti.util.PanelUtils;
import dr.app.gui.components.RealNumberField;
import dr.app.gui.components.WholeNumberField;
import dr.app.util.OSType;
import dr.evolution.datatype.DataType;
import jam.panels.OptionsPanel;
Expand Down
12 changes: 1 addition & 11 deletions src/dr/evomodelxml/operators/NodeHeightOperatorParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ public enum OperatorType {
RANDOMWALK("random walk"),
SCALEROOT("scale root"),
SCALEALL("scale all internal");
// MULTIMOVEUNIFORM("multiMoveUniform");
// -JT the order in which nodes are picked matters but there is more than
// one way to pick the nodes I don't trust the multimove operator


OperatorType(String name) {
this.name = name;
Expand Down Expand Up @@ -107,12 +105,6 @@ public Object parseXMLObject(XMLObject xo) throws XMLParseException {
throw new XMLParseException("The UniformNodeHeightOperator scaleFactor attribute must be between 0 and 1.");
}
}
// if (xo.hasAttribute(MEAN_COUNT)) {
// tuningParameter = xo.getDoubleAttribute(MEAN_COUNT);
// if (tuningParameter <= 0.0) {
// throw new XMLParseException("The UniformNodeHeightOperator nonshifted mean attribute must be positive and non-zero.");
// }
// }

final double targetAcceptance = xo.getAttribute(TARGET_ACCEPTANCE, 0.234);

Expand All @@ -126,8 +118,6 @@ public Object parseXMLObject(XMLObject xo) throws XMLParseException {
case SCALEROOT:
case SCALEALL:
return new ScaleNodeHeightOperator(treeModel, weight, tuningParameter, operatorType, mode, targetAcceptance);
// case MULTIMOVEUNIFORM:
// return new MultiMoveUniformNodeHeightOperator(treeModel, weight, tuningParameter,mode,targetAcceptance);
default:
throw new IllegalArgumentException("Unknown operator type");
}
Expand Down

0 comments on commit e6d89aa

Please sign in to comment.