-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility specs / resolve accessibility errors. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 17, 2024
houndci-bot
reviewed
Jun 17, 2024
houndci-bot
reviewed
Jun 17, 2024
Elements can be excludes from test cases with the attribute data-a11y-external-errors="true"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sitemap.xml
which means the (trivial) redirect page isn't tested.To run tests locally:
bundle install
bundle exec rspec
bundle exec rspec --next-failure
to quickly iterate through tests 1 by 1you will need Google Chrome and a matching chromedriver installed (
brew install chromedriver
works well.)Customizing Tests
Workarounds
Having a Green CI suite is very useful. Don't let tests fail because there's one impossible condition. Use the attribute
data-a11y-external-errors="true"
to exclude an element from the axe test failures.excluded_elements
array in the accessibility specs. (See https://github.com/beautyjoy/beautyjoy.github.io/pull/269/files#diff-4aa11e0c6d635527894cafc21aa2fb01be2a447bd92fd2e410463e45310bd025R43) ...Arguably, we should disable as few tests as possible for specific elements, though this can lead to more confusion than necessary at times.The name of these exclusions is intended to make it clear that some element is inaccessible. It should be clear to other authors that this is something that should be addressed in the future.
Accessibility Changes: