Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy checks #184

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Fix mypy checks #184

merged 6 commits into from
Oct 29, 2024

Commits on Dec 13, 2023

  1. Make a note in toxfile

    @browniebroke
    browniebroke committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9a1c60f View commit details
    Browse the repository at this point in the history

  2. Install latest version of djangorestframework-stubs, with correct ver… 

    …sion of mypy
    @browniebroke
    browniebroke committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    22b4214 View commit details
    Browse the repository at this point in the history

  3. Finish running the whole CI matrix before stopping

    @browniebroke
    browniebroke committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a88cecf View commit details
    Browse the repository at this point in the history

  4. Ignore type error from mypy 

    error: "type[UFMChild]" has no attribute "objects"  [attr-defined]

It's a Django model, this attribute exists...
    @browniebroke
    browniebroke committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    dcdd232 View commit details
    Browse the repository at this point in the history

  5. Add --show-traceback to mypy runs

    @browniebroke
    browniebroke committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    22770e6 View commit details
    Browse the repository at this point in the history

  6. Don't run mypy on older versions of Django

    @browniebroke
    browniebroke committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f99bdda View commit details
    Browse the repository at this point in the history