-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing program to be used by pmm as sudo #294
base: master
Are you sure you want to change the base?
Conversation
Also should be doas.conf added |
I agree we should make this configurable. In retrospect I'm surprised I didn't do so when first writing this subsystem. I'd rather not make the configuration item called
Ideally yes. However, a quirk in how The proper way to handle this is to move the existing I'm reworking the configuration system in 0.8 to make the behavior around adding new global items less surprising.
0.7 doesn't have good automation to automatically configure this, and trying to add some now is a bit risky as if it doesn't work it could lock people out of root permissions needed to undo the change. Improving the auto-configuration subsystem is another goal for 0.8. |
Sounds like good plan, i'll try implement that |
This seems to work, any thoughts? |
12e1061
to
524beae
Compare
This pr adds config value [pmm]
sudo
which can be used to change sudo program to for exampledoas
.Not sure if the flags
-u
should part of the config value. Doing so would perhaps allow more flexibility.I don't know awk very well so it might be completelly wrong but it seems to work on my machine.