Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for getDerivedStateFromProps #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

walaman
Copy link

@walaman walaman commented Oct 16, 2019

Trying to fix issue #84

Changed

  • _calculateHeight() && get styles() out of class
  • Use getDerivedStateFromProps instead of componentWillReceiveProps

@EJohnF
Copy link

EJohnF commented Nov 8, 2019

for me seems to work, thanks :)

@MaxInMoon
Copy link

Could it be mergeable?

@lukasa1993
Copy link

will this be merged?

@klimdead
Copy link

Any updates for merge?

@pke
Copy link

pke commented Jun 3, 2020

Thanks for the PR. Maybe @xiaoyann could merge?

@Santo-dev
Copy link

Santo-dev commented Jul 9, 2020

Maybe @xwenliang @skyRen @xiaoyann @chunyanzhu @penghongsun or @skinTest can merge? Thanks in advance guys, it would be great for all of us. And Thank you @walaman for your work.

@walaman
Copy link
Author

walaman commented Jul 9, 2020

@walaman Is it possible to merge ? It would be great for all of us. Thanks in advance.

Sorry Im not the owner, and I don't have the permission to merge it.
Seems this project have been abandoned and outdate, it would be better to rewrite using react hook

@alessiocancian
Copy link

I released the fix to npm, read #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants