Refactor validatePools: add more CLM validation #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReflectiveChimp
requested review from
MirthFutures,
roman-monk and
kexleyBeefy
✅ Deploy Preview for thunderous-cow-9b0405 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/validatePools.ts - almost everything can be configured from the
optionsobjectscripts/validate/vault/validators.ts - list of validate functions
vaultValidatorsrun for each vault typescripts/validate/vault/data.ts - how on chain data is fetched for each vault type
boost + platform config validation unchanged
new validations
CLM
validates platformId is beefy
validates strategyTypeId is correct based on tokenProviderId
CLM Pool/Vault
validates platformId, tokenProviderId and strategyTypeId match base CLM
cli options
--verboseto see output of each test for each vault [default: false]--no-colordisable coloring of output [default: false, color enabled if supported]output