Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse sync chief complaints of the patient #15

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

babstar93
Copy link
Collaborator

@babstar93 babstar93 commented Aug 23, 2023

For testing:
http://{{baseUrl}}:{{port}}/fhir/Condition?providerServiceMapId=10&vanID=3&lastModif=lt2023-08-01

Curl:
curl --location 'http://{{baseUrl}}:{{port}}/fhir/Condition?providerServiceMapId=10&vanID=3&lastModif=lt2023-08-01'
--header 'Accept: application/json'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the imports and auto wiring, I don't see any changes here. Undo this as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this logic is related to the condition controller, it's better to write it in the condition service class(already present). That way our code will be better isolated from theirs and easy to follow and we will not be modifying their code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

condition.setBenFlowID(new StringType(beneficiaryFlowStatus.getBenFlowID()+""));
}
else {
throw new ResourceNotFoundException("No record found for given benVisitID and BenVisitCode");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of throwing exception, log it as no benVisitID and BenvisitCode. Add continue statement to ignore the record. Can we write in the query to get only records with benVistiID and BenvisitCode?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I even think that we don't need to generate an exception because the benVisitID and the visitCode will exist all the time. So I removed the generation of an exception @roopesh-beehyv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants