Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Dependencies #516

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Upgrading Dependencies #516

wants to merge 30 commits into from

Conversation

TheBurchLog
Copy link
Contributor

No description provided.

@TheBurchLog TheBurchLog changed the title Python 3 9 support Upgrading Dependencies Nov 1, 2024
@TheBurchLog TheBurchLog requested a review from 1maple1 December 5, 2024 19:12
@TheBurchLog TheBurchLog marked this pull request as ready for review December 5, 2024 19:12
brewtils/schema_parser.py Outdated Show resolved Hide resolved

class ChoicesSchema(BaseSchema):
type = fields.Str(allow_none=True)
display = fields.Str(allow_none=True)
value = fields.Raw(allow_none=True, many=True)
strict = fields.Bool(allow_none=True, default=False)
strict = fields.Bool(allow_none=True, dump_default=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using dump_default is ugly, but confirmed that this the way to do it in marshmallow 3.13+.

Copy link
Contributor

@1maple1 1maple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one actual comment about a possible unused import. The major fixes for changes to function names, pre and post_load, and the schema changes are all there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants