-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading Dependencies #516
base: develop
Are you sure you want to change the base?
Conversation
|
||
class ChoicesSchema(BaseSchema): | ||
type = fields.Str(allow_none=True) | ||
display = fields.Str(allow_none=True) | ||
value = fields.Raw(allow_none=True, many=True) | ||
strict = fields.Bool(allow_none=True, default=False) | ||
strict = fields.Bool(allow_none=True, dump_default=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using dump_default is ugly, but confirmed that this the way to do it in marshmallow 3.13+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one actual comment about a possible unused import. The major fixes for changes to function names, pre and post_load, and the schema changes are all there.
No description provided.