Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python 3.11 - 3.13 on Android #99

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Oct 22, 2024

All the necessary wheels have now been released.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith
Copy link
Member Author

mhsmith commented Oct 22, 2024

iOS failed to get the test result twice in a row, on different Python versions, but that doesn't seem to have anything to do with this PR:

@mhsmith mhsmith requested a review from freakboy3742 October 22, 2024 12:47
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android changes look good; but we can walk back the iOS changes. I'll get those rolled back now.

python-version: "3.13-dev"
# numpy and pandas aren't available for 3.13 on iOS
- backend: "iOS"
python-version: "3.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can run the test suite on iOS; we just can't run the numpy and pandas tests; but they should be resilient to the package not being present.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For that matter, the 3.13 support packages exist for flatpaks and Windows.

@freakboy3742 freakboy3742 merged commit 8cb8525 into beeware:main Oct 23, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants