Console app on convert #169
Conversation
cookiecutter.json
Outdated
| @@ -28,6 +28,7 @@ | |||
| ], | |||
| "app_source": "", | |||
| "app_start_source": "", | |||
| "console_app": "", | |||
There was a problem hiding this comment.
| "console_app": "", | |
| "console_app": false, |
| @@ -19,6 +19,9 @@ sources = [ | |||
| test_sources = [ | |||
| "{{ cookiecutter.test_source_dir }}", | |||
| ] | |||
| {% if cookiecutter.console_app %} | |||
| console.app = "{{cookiecutter.console_app}}" | |||
There was a problem hiding this comment.
| console.app = "{{cookiecutter.console_app}}" | |
| console_app = {{ cookiecutter.console_app }} |
There was a problem hiding this comment.
I think the if statement should stay to avoid clash between new and convert commands, new command uses pyproject_table_briefcase_app_extra_content attribute while convert command will use console_app attribute, if we do not use if statement we can have console_app statement twice in pyproject.toml, or we can refactor new command to use this attribute.
There was a problem hiding this comment.
I think you've misunderstood the suggestion I'm making here. I agree that the if statement should be retained; the suggestion is that console.app (period, rather than underscore) is the wrong key to use, and the value shouldn't be quoted.
logan-keede
force-pushed
the
console_app_on_convert
branch
from
b3509b6 to
1fefb9a
Compare
PR Checklist:
to add console_app in template
Refs beeware/briefcase#1900 beeware/briefcase#2089