Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a more extensive default bootstrap #2006 #2045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Xzenergy
Copy link

PR Checklist:

  • [x ] All new features have been tested
  • [x ] All new features have been documented
  • [x ] I have read the CONTRIBUTING.md file
  • [x ] I will abide by the code of conduct

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but there's a couple of issues here.

Firstly, our contribution guide details how to set up a pull request so it has the best chance of passing CI. At present, your PR is failing some basic checks.

More importantly, the implementation isn't really solving the problem. You've added an "empty.toml"... which doesn't reflect the way any of the other bootstraps are defined. You've also made a lot of changes to the new and convert commands that only appears to mention the Toga and Empty templates... missing the other pre-existing templates. Lastly, you've added something to briefcase.toml... but the code you've added won't do anything.

A better approach for this would be to take an existing bootstrap, search for everywhere in the code that it is mentioned, and duplicate those references - i.e., create a "toga2" bootstrap and then rename that bootstrap "empty" - then use that bootstrap when "no GUI template" is specified (the current "None") option.

@Xzenergy
Copy link
Author

Thanks for the PR, but there's a couple of issues here.

Firstly, our contribution guide details how to set up a pull request so it has the best chance of passing CI. At present, your PR is failing some basic checks.

More importantly, the implementation isn't really solving the problem. You've added an "empty.toml"... which doesn't reflect the way any of the other bootstraps are defined. You've also made a lot of changes to the new and convert commands that only appears to mention the Toga and Empty templates... missing the other pre-existing templates. Lastly, you've added something to briefcase.toml... but the code you've added won't do anything.

A better approach for this would be to take an existing bootstrap, search for everywhere in the code that it is mentioned, and duplicate those references - i.e., create a "toga2" bootstrap and then rename that bootstrap "empty" - then use that bootstrap when "no GUI template" is specified (the current "None") option.

Thanks so much for the feedback, this is my first attempt at contributing anything to anywhere! Thanks for the contributions guide, I hadn't visited that yet. I'll do some reading and then try to re-tackle the problem. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants