Correct Pillow builds on x86 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CI configuration to verify x86 builds for Pillow, and corrects the recipe for Pillow to disable the "standard locations" (
/usr,/usr/localetc). This was being done in mobile-forge, but Pillow was Helping and adding them back in.Also adds numpy builds to verify behaviour reported by #60. The path to the stub binary in CI is
/Users/runner/work/mobile-forge/mobile-forgebuild/cp312/numpy/1.26.2/venv3.12-ios_13_0_arm64_iphoneos/cross/lib/python3.12, which is 123 characters, just under the 127 character limit that would have triggered the bug.Lastly, corrects some issues with the numpy recipe that were revealed when trying to build numpy on x86_64. These mostly stemmed from incorrectly configuring the C++ compiler, and not updating the patch to reflect the change in ordering of the MULTIARCH tag.
Fixes #60.
Fixes #62.
PR Checklist: