Fixed value check in property assignment #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the dataclass restructuring, property assignment checked against
getattr(self, "_%s" % name, initial)
to see if a change had occurred and the property would need to be applied. I overlooked this and usedNone
as the default instead ofinitial
.This didn't really make anything work incorrectly; however, a previously unassigned property being assigned a value equal to its initial value then triggers an unnecessary apply.
I've reverted it to
getattr(obj, f"_{self.name}", self.initial)
.PR Checklist: