-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use extended control API, libv4l and various bugfixes #25
base: master
Are you sure you want to change the base?
Conversation
It builds with warnings
|
Now it builds cleanly (the error and failure functions are const'ed) |
@iglosiggio this patch removes two methods. This is an API break and, from what I can understand, unrelated to the fix at hand for the extended controls? |
The patch also introduces a new dependency, v4-utils. Because it is not installed on Travis CI the build fails. Is this neccesary for using extended controls, or can it be done with the regular Btw, not the maintainer, just someone who needs the same functionality. |
After i submitted the patch i kept working on the fork to fulfill my needs
(even removing deprecated code).
If you want an "only extended api patch" i will create that branch when i
arrive to my work ^^
El 2 dic. 2016 8:17 AM, "Jon Nordby" <[email protected]> escribió:
… @iglosiggio <https://github.com/iglosiggio> this patch removes two
methods. This is an API break and, from what I can understand, unrelated to
the fix at hand for the extended controls?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGeeDe6_pnqUPXkNE1zztYJM52VV8rXks5rD_5CgaJpZM4KaMqP>
.
|
libv4l adds automatic conversion to RGB (because of that i removed the toRGB and toYUV methods) |
All the irrelevant changes are after iglosiggio@8056390 |
@iglosiggio I think the chance of this getting merged will go up substantially if only the relevant changes are included, so a dedicated branch and updating the PR to point to that would be great. |
Remove use of FunctionCallbackInfo::Callee v8 api removed in https://chromium-review.googlesource.com/c/v8/v8/+/741600/
Add support for stepwise framesizes and intervals
I've needed to disable auto-exposure on a webcam and the control wasn't available because was part of the extended control (device specific ones). This little patch should work, i'll be testing it during the week.
Anyways, thanks for the bindings!