Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extended control API, libv4l and various bugfixes #25

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

iglosiggio
Copy link

I've needed to disable auto-exposure on a webcam and the control wasn't available because was part of the extended control (device specific ones). This little patch should work, i'll be testing it during the week.

Anyways, thanks for the bindings!

@iglosiggio
Copy link
Author

It builds with warnings

../capture.c: In function ‘camera_controls_menus’:
../capture.c:468:13: warning: passing argument 1 of ‘error’ discards ‘const’ qualifier from pointer target type
       error(camera, "VIDIOC_QUERYMENU");
             ^
../capture.c:28:13: note: expected ‘struct camera_t *’ but argument is of type ‘const struct camera_t *’
 static bool error(camera_t* camera, const char * msg)

@iglosiggio
Copy link
Author

Now it builds cleanly (the error and failure functions are const'ed)

@jonnor
Copy link

jonnor commented Dec 2, 2016

@iglosiggio this patch removes two methods. This is an API break and, from what I can understand, unrelated to the fix at hand for the extended controls?

@jonnor
Copy link

jonnor commented Dec 2, 2016

The patch also introduces a new dependency, v4-utils. Because it is not installed on Travis CI the build fails. Is this neccesary for using extended controls, or can it be done with the regular ioctl?

Btw, not the maintainer, just someone who needs the same functionality.

@iglosiggio
Copy link
Author

iglosiggio commented Dec 2, 2016 via email

@iglosiggio
Copy link
Author

libv4l adds automatic conversion to RGB (because of that i removed the toRGB and toYUV methods)

@iglosiggio
Copy link
Author

All the irrelevant changes are after iglosiggio@8056390

@jonnor
Copy link

jonnor commented Dec 2, 2016

@iglosiggio I think the chance of this getting merged will go up substantially if only the relevant changes are included, so a dedicated branch and updating the PR to point to that would be great.
I also tested the commits here locally, they seems to work fine.

@iglosiggio iglosiggio changed the title Use extended control API Use extended control API, libv4l and various bugfixes Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants