Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border image #274

Merged
merged 10 commits into from
Feb 10, 2023
Merged

Border image #274

merged 10 commits into from
Feb 10, 2023

Conversation

fadelun
Copy link
Contributor

@fadelun fadelun commented Jan 26, 2023

Deskripsi (Description)

Memberikan penjelasan dan contoh tentang border image

Checklist:

Umum:
  • Saya menambah kode basic terbaru.
  • Saya memperbaiki kode basic yang sudah ada.
  • Saya menambah template terbaru.
  • Saya memperbaiki template yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = windows

Testing

  • link html
  • link css

linked issue #204

@mergify mergify bot requested a review from a team January 26, 2023 15:14
AdityaFitrianaNS
AdityaFitrianaNS approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@AdityaFitrianaNS AdityaFitrianaNS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! btw itu commit pull request yang sebelumnya masih terbawa kak

@fadelun
Copy link
Contributor Author

fadelun commented Jan 28, 2023

thank you kak

nu07
nu07 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@nu07 nu07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! MANTAPUUU!!!!

@nu07 nu07 added the ready-to-merge siap merge label Feb 10, 2023
@mergify mergify bot merged commit b513da0 into bellshade:main Feb 10, 2023
@mergify
Copy link

mergify bot commented Feb 10, 2023

terima kasih atas kontribusinya @fadelun !

@mergify mergify bot requested a review from a team February 10, 2023 18:03
kingramzy
kingramzy reviewed Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@kingramzy kingramzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM semua kan? okey

@mergify mergify bot requested a review from a team February 25, 2023 13:55
kingramzy
kingramzy reviewed Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@kingramzy kingramzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot requested a review from a team February 25, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingramzy kingramzy kingramzy left review comments

@AdityaFitrianaNS AdityaFitrianaNS AdityaFitrianaNS approved these changes

@nu07 nu07 nu07 approved these changes

@dhafitf dhafitf Awaiting requested review from dhafitf dhafitf is a code owner

Assignees
No one assigned
Labels
html files markdown files ready-to-merge siap merge sudah direview !
Projects
Bellshade 2022 v2
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fadelun @kingramzy @nu07 @AdityaFitrianaNS