Naming consistency and mistyped sign - Maxwell dielectric Notebook #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple; in particular the external fields were not referered with the plus sign everywhere, and also there was a mistyped sign relating incident, scattered and total fields.
|
And actually, I used "tangential" when I should have used "rotated tangential" for the trace (following Hiptmair's naming convention), sorry for that! |
deweatherman
changed the title
Exn defines a rotated version of the actual tangential component of E (given by nx(Exn)
|
I will try a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In first markdown cell, where the theory behind the example is given, there were a couple of inconsistencies:
Other changes appearing when comparing the versions are irrelevant (I re-ran the notebook locally, thus a bunch of irrelevant info is there).