Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the tab width error. #1

Open
wants to merge 1 commit into
base: java11
Choose a base branch
from

Conversation

madhephaestus
Copy link

In the Java11 implementation there is an error with the off-screen tabs button. The button which opens a menu of all the tabs in the pain lets you select off screen buttons. In Java11 this menu comes up with blank names.

The solution is to make the tabs auto size so they never fall off the screen. A tooltip is added to read the titles of tabs that are too small to read.

@ben-kemister
Copy link
Owner

ben-kemister commented May 5, 2023

Hi,
Thanks for the PR. Sorry for taking so long to review, it looks like I didn't get any notification when you created the PR.
This bug had been bothering me as well and only just managed to have a loot at it.

I found a solution where the Dock node/tab labels (and graphic) would actually be shown in the TabMenuItem as you would expect.
Take a look at commit: 84333ae
This doesn't prevent the tabs being 'off-screen' but does mean that the menu works properly when they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants