Use abi3 wheels to support arbitrary Python versions
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust is available on GitHub hosted runners anyway.
Otherwise build fails with this error:
+ delocate-wheel --require-archs x86_64 -w /private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/repaired_wheel -v /private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/built_wheel/cpp_demangle-0.1.2-cp38-abi3-macosx_10_12_x86_64.whl
Fixing: /private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/built_wheel/cpp_demangle-0.1.2-cp38-abi3-macosx_10_12_x86_64.whl
Traceback (most recent call last):
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/bin/delocate-wheel", line 8, in <module>
sys.exit(main())
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/lib/python3.8/site-packages/delocate/cmd/delocate_wheel.py", line 116, in main
copied = delocate_wheel(
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/lib/python3.8/site-packages/delocate/delocating.py", line 1090, in delocate_wheel
out_wheel_fixed = _check_and_update_wheel_name(
File "/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/cibw-run-4aju7ur6/cp38-macosx_x86_64/build/venv/lib/python3.8/site-packages/delocate/delocating.py", line 925, in _check_and_update_wheel_name
raise DelocationError(
delocate.libsana.DelocationError: Library dependencies do not satisfy target MacOS version 10.9:
/private/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/tmp9i_sockf/wheel/cpp_demangle.abi3.so has a minimum target of 10.12
Set the environment variable 'MACOSX_DEPLOYMENT_TARGET=10.12' to update minimum supported macOS for this wheel.
See this build warning:
Warning: cibuildwheel: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Enable it using the `enable` option or remove this selector. This selector will have no effect.
|
@benfred I don't want to nag you, but it would be awesome if you could take a look at this PR. It should make py-cpp-demangle forward compatible with any new Python release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this package does not use any special part of the CPython interface, it can leverage the stable abi, not needing version specific wheels.
This supersedes #11. I also needed to update the github actions to make them work again, so this PR also makes #14 obsolete.