Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CSV lines in at most 2 places #17

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

Gobbel2000
Copy link
Contributor

Previously, if a transition label contained a comma, the CSV loader would truncate the label there.
This causes the following lines to be considered as transitions with the same label of "s4(d1":

66,98,"s4(d1,first)"
1636,1674,"s4(d1,last)"

The above transitions are found in the cwi_1_2.csv benchmark file. This issue caused only 9 enabledness-classes to be detected instead of 11.

This fix changes the behavior so that a line is split in at most 3 parts, everything after the second comma goes into the label.

Copy link
Owner

@benkeks benkeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@benkeks benkeks merged commit cc515f0 into benkeks:main Mar 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants