Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprications and add unit of measurement to battery_level sensor #53

Closed
wants to merge 41 commits into from

Conversation

ChristophCaina
Copy link
Contributor

  • fix deprication warnings for HA 2024.1 #
  • fix missing Unit_of_Measurement for sensor Battery_Level

at least, partially fixed issues:

#45
#51
#44
#36
#31

@ChristophCaina
Copy link
Contributor Author

c143558 - adds german translation

Copy link

@paulcombuse paulcombuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulcombuse
Copy link

@benleb please create a pull request with the changes of @ChristophCaina - many thanks! 🍺

@blair287
Copy link

@benleb please create a pull request with the changes of @ChristophCaina - many thanks! 🍺

Don't think he is around anymore so not sure we will be getting anymore updates.

@pdwonline
Copy link

pdwonline commented Jun 28, 2024

Anyone willing to share a fork for this as it seems stale?

@ChristophCaina
Copy link
Contributor Author

I mean, I can revert other changes I've made in my fork - and provide the fork "as is" - but I cannot provide more support on the component.

For the time being, you could manually put the changes into the folder of your custom_component.

fixes deprication warnings from HA 2024.4.0 and 2024.7.0
close #14
changed version & codeowner + repository-link
…rom-HA-2024.4-and-2024.7

Fix deprication warnings from ha 2024.4 and 2024.7
@benleb
Copy link
Owner

benleb commented Jul 19, 2024

please ping me when you are "ready" :) 👍

@ChristophCaina
Copy link
Contributor Author

ChristophCaina commented Jul 19, 2024

Hi, ready for what? ^^
I can submit a pr based in the current Progress - I've created new File struckture and Made it ready for releases ...
But this pr should also Contain all relevant Changes

Are you in discord?

README.md Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant merge it with this 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol... ok.
I honestly thought, I removed that already...
Seems that it was re-added with recent changes.

Sorry

@benleb
Copy link
Owner

benleb commented Jul 19, 2024

ready for merge :D For example the readme file (see the comment) seems not ready to be merged (and maybe some other files too?) :)

delete because of merge :)
delete because of merge
@ChristophCaina ChristophCaina marked this pull request as draft July 19, 2024 09:17
@ChristophCaina
Copy link
Contributor Author

I'll create a new Pull-request... sorry...

@benleb
Copy link
Owner

benleb commented Jul 19, 2024

all good, np :) 👍 thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants